Skip to content

Add support for resolving catalogItemId via catalogItemSlug#18

Merged
sergio-esperalta-bi merged 13 commits intomasterfrom
feature/Update-Provisioning-Endpoint-to-Support-catalogItemSlug-as-Alternative-to-catalogItemId
Apr 20, 2026
Merged

Add support for resolving catalogItemId via catalogItemSlug#18
sergio-esperalta-bi merged 13 commits intomasterfrom
feature/Update-Provisioning-Endpoint-to-Support-catalogItemSlug-as-Alternative-to-catalogItemId

Conversation

@sergio-esperalta-bi
Copy link
Copy Markdown
Contributor

@sergio-esperalta-bi sergio-esperalta-bi commented Apr 15, 2026

What does this implement/fix?

This pull request adds the capability to resolve catalogItemId using catalogItemSlug in provisioning operations.

Does this close any currently open issues?

No.

Any relevant logs, error output, etc.?

N/A

Where has this been tested?

  • Environment: Tested in local environment against development.

Checklist

  • I have added tests that prove my fix is effective or that my feature works.
  • I have added necessary documentation (if appropriate).

Copy link
Copy Markdown
Contributor

@sergio-soria-bi sergio-soria-bi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In summary, there should not be any idToken in the code since the changes we worked yesterday on.

…pport-catalogItemSlug-as-Alternative-to-catalogItemId

# Conflicts:
#	src/main/java/org/opendevstack/component_provisioner/server/controllers/ProvisionResultsApiController.java
#	src/main/java/org/opendevstack/component_provisioner/server/facade/ProvisionResultsApiFacade.java
#	src/test/java/org/opendevstack/component_provisioner/server/controllers/ProvisionResultsApiControllerTest.java
#	src/test/java/org/opendevstack/component_provisioner/server/facade/ProvisionResultsApiFacadeTest.java
…teRequest`, enhance type map initialization, and add corresponding unit tests.
Copy link
Copy Markdown
Contributor

@sergio-soria-bi sergio-soria-bi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks fine to me

anyway, I do not like how we do mapping in this project, nothing to be with this review, but as we are adding new mappings... please do deep test in DEV before merging to master.

…gItemId` logic, adding related test enhancements.
@sonarqubecloud
Copy link
Copy Markdown

@sergio-esperalta-bi sergio-esperalta-bi merged commit de3ee13 into master Apr 20, 2026
3 checks passed
@sergio-esperalta-bi sergio-esperalta-bi deleted the feature/Update-Provisioning-Endpoint-to-Support-catalogItemSlug-as-Alternative-to-catalogItemId branch April 20, 2026 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants